Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added registry key to disable fission flag #6041

Merged
merged 2 commits into from Feb 29, 2024

Conversation

LeFrosch
Copy link
Collaborator

@LeFrosch LeFrosch commented Feb 8, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #5604

Description of this change

Adds a new registry key bazel.clwb.debug.fission.disabled which can be used to prevent CLion from adding the --fission=yes flag automatically. This was mentioned as a workaround in the discussion of the issue.

@github-actions github-actions bot added product: CLion CLion plugin awaiting-review Awaiting review from Bazel team on PRs labels Feb 8, 2024
"--test_timeout=3600",
BlazeFlags.NO_CACHE_TEST_RESULTS,
BlazeFlags.EXCLUSIVE_TEST_EXECUTION,
BlazeFlags.DISABLE_TEST_SHARDING);

// Allows the fission flag to be disabled as workaround for
// https://github.com/bazelbuild/intellij/issues/5604
static ImmutableList<String> fissionFlag() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be like getOptionalFissionArguments?

Copy link
Collaborator

@ujohnny ujohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ujohnny ujohnny merged commit bfe6868 into bazelbuild:master Feb 29, 2024
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants