Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rely on the bazel zipper instead of zip #6357

Closed
wants to merge 1 commit into from

Conversation

blorente
Copy link
Collaborator

@blorente blorente commented Apr 2, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

Re-opening of #6328 after fixing the issues.

zip might not be available in all machines. Specifically, it might not be available in Remote Build Execution environments. Instead, we use Bazel's built-in zipper.

@tpasternak
Copy link
Collaborator

might be related #6468

@blorente
Copy link
Collaborator Author

blorente commented Jun 6, 2024

Duplicate of #6462

@blorente blorente marked this as a duplicate of #6462 Jun 6, 2024
@mai93
Copy link
Collaborator

mai93 commented Jun 26, 2024

closing as #6462 is merged

@mai93 mai93 closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants