Add extension point to detect whether a module is to be orphaned or retained. #6467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchandu25
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: CLion
dkashyn-sfdc
reviewed
Jun 5, 2024
base/src/com/google/idea/blaze/base/sync/projectstructure/OrphanedModuleValidator.java
Outdated
Show resolved
Hide resolved
dkashyn-sfdc
reviewed
Jun 6, 2024
base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleEditorImpl.java
Outdated
Show resolved
Hide resolved
dkashyn-sfdc
reviewed
Jun 6, 2024
base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleEditorImpl.java
Outdated
Show resolved
Hide resolved
dkashyn-sfdc
reviewed
Jun 6, 2024
base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleValidator.java
Outdated
Show resolved
Hide resolved
dkashyn-sfdc
reviewed
Jun 6, 2024
base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleEditorImpl.java
Outdated
Show resolved
Hide resolved
tpasternak
reviewed
Jun 7, 2024
base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleEditorImpl.java
Outdated
Show resolved
Hide resolved
base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleValidator.java
Outdated
Show resolved
Hide resolved
gchandu25
force-pushed
the
bazel-sync-keep-mavenModules
branch
from
c220215
to
c9d51b0
Compare
dkashyn-sfdc
reviewed
Jun 9, 2024
| ExtensionPointName<ExternalModuleProvider> EP_NAME = | ||
| ExtensionPointName.create("com.google.idea.blaze.base.sync.projectstructure.ExternalModuleProvider"); | ||
|
|
||
| boolean isOwnedByExternalModule(Module module); |
There was a problem hiding this comment.
it is not really externalModule that own this module but it is much better than validation so I'll approve (not that it matters :) )
There was a problem hiding this comment.
yeah, if it was an internal name I would change it afterwards, but this is an EP, so let's avoid changes once its merged. Could you please change that to isOwnedByExternalPlugin or isOwnedByThirdPartyPlugin?
There was a problem hiding this comment.
updated to 'isOwnedByExternalPlugin'. Please a take @tpasternak.
tpasternak
previously requested changes
Jun 10, 2024
| ExtensionPointName<ExternalModuleProvider> EP_NAME = | ||
| ExtensionPointName.create("com.google.idea.blaze.base.sync.projectstructure.ExternalModuleProvider"); | ||
|
|
||
| boolean isOwnedByExternalModule(Module module); |
There was a problem hiding this comment.
yeah, if it was an internal name I would change it afterwards, but this is an EP, so let's avoid changes once its merged. Could you please change that to isOwnedByExternalPlugin or isOwnedByThirdPartyPlugin?
gchandu25
force-pushed
the
bazel-sync-keep-mavenModules
branch
from
e9f7069
to
b899b34
Compare
jastice
approved these changes
Jun 13, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>Description of this change
Added an EP to give the feasibility to allow other modules. For example, when maven modules are added into project view bazel sync resets the view as they have different content root. An implementation could be added to allow maven modules to be shown in project tree view.