Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolchain built in includes to compiler switches #6487

Closed
wants to merge 2 commits into from

Conversation

LeFrosch
Copy link
Collaborator

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #6486

Description of this change

Add toolchain built in includes to compiler switches. Closes #6486.

@LeFrosch LeFrosch marked this pull request as ready for review June 17, 2024 09:49
@github-actions github-actions bot added product: CLion CLion plugin awaiting-review Awaiting review from Bazel team on PRs labels Jun 17, 2024
@LeFrosch LeFrosch requested a review from ujohnny June 17, 2024 09:50
@LeFrosch
Copy link
Collaborator Author

This might not be necessary after all. Because CLion can retrieve builtin includes from the compiler directly. Investigating why this was not working in my case.

Copy link
Collaborator

@ujohnny ujohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait for another round of investigations whether we need this change or not

@LeFrosch
Copy link
Collaborator Author

After further investigation I do not think this is necessary.

@LeFrosch LeFrosch closed this Jun 24, 2024
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CcToolchainInfo.built_in_include_directories are not added to include directories
3 participants