Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: java_tools_javac11-v3.0 #11

Closed
iirina opened this issue Jul 4, 2019 · 7 comments
Closed

release: java_tools_javac11-v3.0 #11

iirina opened this issue Jul 4, 2019 · 7 comments
Assignees
@iirina
Labels
P2 P2 We'll consider to work on this in future. (Assignee optional) release

Comments

@iirina
Copy link
Contributor

iirina commented Jul 4, 2019 •
edited
Loading

This new release contains loading @rules_java statements inside the java_tools BUILD file.

This issue follows the java_tools release process.

release candidates can be found under bazel_java_tools/release_candidates/javac11/v3.0
@iirina iirina self-assigned this Jul 4, 2019
@iirina iirina added the P2 P2 We'll consider to work on this in future. (Assignee optional) label Jul 4, 2019
@iirina
Copy link
Contributor Author

iirina commented Jul 4, 2019

Started pipeline for rc1: https://buildkite.com/bazel-trusted/java-tools-binaries-java/builds/117

@iirina
Copy link
Contributor Author

iirina commented Jul 5, 2019

Pipeline finished successfully. However I decided to put on hold the release and wait for a bazel change that adds a load statement for @rules_cc in java_tools's BUILD file.

Since RC1 was not created in GCS I'll re-trigger a new pipeline with a new commit hash for RC1.

@iirina
Copy link
Contributor Author

iirina commented Jul 9, 2019

Starting all over again:

Pipeline for rc 1: https://buildkite.com/bazel-trusted/java-tools-binaries-java/builds/118

Commit hash: a639b562ac7f9d1d7997d1b9ab46a8b4657dd09d

@iirina
Copy link
Contributor Author

iirina commented Jul 9, 2019 •
edited
Loading

Creating RC1:

$ export COMMIT_HASH=a639b562ac7f9d1d7997d1b9ab46a8b4657dd09d
$ export JDK_VERSION=11
$ export NEW_VERSION=3.0
$ export RC=1
$ src/create_java_tools_release.sh --commit_hash $COMMIT_HASH \
--java_tools_version $NEW_VERSION --java_version $JDK_VERSION --rc $RC --release false

release_candidates/javac11/v3.0/java_tools_javac11_linux-v3.0-rc1.zip 10d6f00c72e42b6fda378ad506cc93b1dc92e1aec6e2a490151032244b8b8df5
release_candidates/javac11/v3.0/java_tools_javac11_windows-v3.0-rc1.zip b688155d81245b4d1ee52cac447aae5444b1c59dc77158fcbde05554a6bab48b
release_candidates/javac11/v3.0/java_tools_javac11_darwin-v3.0-rc1.zip 28989f78b1ce437c92dd27bb4943b2211ba4db916ccbb3aef83696a8f9b43724

@iirina iirina mentioned this issue Jul 9, 2019
Closed
@iirina
Copy link
Contributor Author

iirina commented Jul 9, 2019 •
edited
Loading

Pipeline for RC1 finished successfully. Upgrading java_tools version in bazel in bazelbuild/bazel#8827

Bazel CI tests started: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/3553#71091e44-91af-4b94-b322-139d5e9c370d

@iirina
Copy link
Contributor Author

iirina commented Jul 9, 2019

All tests passed on Bazel CI, releasing RC1:

$ src/create_java_tools_release.sh \
--java_tools_version $NEW_VERSION --java_version $JDK_VERSION --rc $RC --release true

releases/javac11/v3.0/java_tools_javac11_linux-v3.0.zip 10d6f00c72e42b6fda378ad506cc93b1dc92e1aec6e2a490151032244b8b8df5
releases/javac11/v3.0/java_tools_javac11_windows-v3.0.zip b688155d81245b4d1ee52cac447aae5444b1c59dc77158fcbde05554a6bab48b
releases/javac11/v3.0/java_tools_javac11_darwin-v3.0.zip 28989f78b1ce437c92dd27bb4943b2211ba4db916ccbb3aef83696a8f9b43724

bazel-io pushed a commit to bazelbuild/bazel that referenced this issue Jul 9, 2019
@iirina
Upgrade java_tools version to javac11-v3.0.
5d94682 
The new java_tools version loads `@rules_java` and `@rules_cc`.

java_tools javac11-v3.0 release can be followed in bazelbuild/java_tools#11.

Closes #8827.

PiperOrigin-RevId: 257175059
@iirina
Copy link
Contributor Author

iirina commented Jul 10, 2019 •
edited
Loading

Version upgraded in Bazel in bazelbuild/bazel@5d94682.

@iirina iirina closed this as completed Jul 10, 2019
irengrig pushed a commit to irengrig/bazel that referenced this issue Jul 15, 2019
@iirina @irengrig
Upgrade java_tools version to javac11-v3.0.
cd96d57 
The new java_tools version loads `@rules_java` and `@rules_cc`.

java_tools javac11-v3.0 release can be followed in bazelbuild/java_tools#11.

Closes bazelbuild#8827.

PiperOrigin-RevId: 257175059
@iirina iirina added the release label Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iirina iirina

Labels
P2 P2 We'll consider to work on this in future. (Assignee optional) release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iirina