Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release darwin aarch64 archives #57

Closed
mauriciogg opened this issue Jun 1, 2022 · 5 comments
Closed

Release darwin aarch64 archives #57

mauriciogg opened this issue Jun 1, 2022 · 5 comments
Labels
P3 We're not considering to work on this, but happy to review a PR. (No assignee)

Comments

@mauriciogg
Copy link

mauriciogg commented Jun 1, 2022

Only x86_64 versions of java_tools exist. M1 macs are becoming the preferred machine for a lot of developers. Ideally there should be architecture specific releases.

@comius comius added the P3 We're not considering to work on this, but happy to review a PR. (No assignee) label Jul 19, 2022
@meteorcloudy
Copy link
Member

@comius This is possible now since Bazel CI has added Apple Silicon machines.

copybara-service bot pushed a commit to bazelbuild/bazel that referenced this issue Feb 27, 2023
Build a fat universal binary for java_tools_prebuilt on darwin

Work towards: bazelbuild/java_tools#57 and #13944

Closes #16960.

PiperOrigin-RevId: 512683379
Change-Id: Ie9db26c729a301fbb22f17dd15065861f3198f57
copybara-service bot pushed a commit to bazelbuild/bazel that referenced this issue Mar 15, 2023
*** Reason for rollback ***

Conflicts with #17762

Will instead go with the alternative idea discussed in this PR: #17767

*** Original change description ***

Add darwin_arm64 java_tools

Build a fat universal binary for java_tools_prebuilt on darwin

Work towards: bazelbuild/java_tools#57 and #13944

Closes #16960.

PiperOrigin-RevId: 516799739
Change-Id: I2ff5f615bd7c23e38a334bf836c31ed964443c31
@hvadehra
Copy link
Member

This is fixed after bazelbuild/bazel#17780 . java_tools for darwin are now separately available for x86_64 and arm64 after v12.0 : https://github.com/bazelbuild/java_tools/releases/tag/java_v12.0

@meteorcloudy
Copy link
Member

@hvadehra How easy is it to cherry pick the java_tools update back to 6.x?

@hvadehra
Copy link
Member

Since bazelbuild/bazel@c9e3eeb was already taken in 6.2.0, is this really needed? That change already added support for java_tools for both darwin architechtures (just with a fat universal binary and not separate binaries).

@meteorcloudy
Copy link
Member

Oh, I see, then we are all good, thanks!

fweikert pushed a commit to fweikert/bazel that referenced this issue May 25, 2023
Build a fat universal binary for java_tools_prebuilt on darwin

Work towards: bazelbuild/java_tools#57 and bazelbuild#13944

Closes bazelbuild#16960.

PiperOrigin-RevId: 512683379
Change-Id: Ie9db26c729a301fbb22f17dd15065861f3198f57
fweikert pushed a commit to fweikert/bazel that referenced this issue May 25, 2023
*** Reason for rollback ***

Conflicts with bazelbuild#17762

Will instead go with the alternative idea discussed in this PR: bazelbuild#17767

*** Original change description ***

Add darwin_arm64 java_tools

Build a fat universal binary for java_tools_prebuilt on darwin

Work towards: bazelbuild/java_tools#57 and bazelbuild#13944

Closes bazelbuild#16960.

PiperOrigin-RevId: 516799739
Change-Id: I2ff5f615bd7c23e38a334bf836c31ed964443c31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering to work on this, but happy to review a PR. (No assignee)
Projects
None yet
Development

No branches or pull requests

4 participants