Add shared zstd decoder pools. #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostynb
reviewed
Feb 19, 2021
go/pkg/client/cas.go
Outdated
| decoderInit.Do(func() { | ||
| decoders = syncpool.NewDecoderPool(zstd.WithDecoderConcurrency(1)) | ||
| }) | ||
|
|
||
| // TODO(rubensf): Reuse decoders when possible to save the effort of starting/closing goroutines. |
There was a problem hiding this comment.
I guess you can remove this TODO?
There was a problem hiding this comment.
Yup - thanks for catching!
go/pkg/client/cas.go
Outdated
| @@ -881,13 +894,14 @@ func NewCompressedWriteBuffer(w io.Writer) (io.WriteCloser, chan error, error) { | |||
| // separate thread. As such, we also need a way to signal the main | |||
| // thread that the decoding has finished - which will have some delay | |||
| // from the last Write call. | |||
| _, err := decoder.WriteTo(w) | |||
| _, err := decoderW.Decoder.WriteTo(w) | |||
There was a problem hiding this comment.
I think this could just be decoderW.WriteTo(w) since the Decoder is embedded. And similarly for the decoderW.Decoder.Reset call further up.
Like #267, but for decoders.
ola-rozenfeld
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing on internal builds yielded improvements :)