Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove output type specification by clients #75

Closed
ola-rozenfeld opened this issue May 9, 2019 · 0 comments · Fixed by #96
Closed

Remove output type specification by clients #75

ola-rozenfeld opened this issue May 9, 2019 · 0 comments · Fixed by #96

Comments

@ola-rozenfeld
Copy link
Contributor

Currently, the client needs to specify on each output whether it is an output_file or an output_directory. This turned out to be too restrictive -- some build tools don't necessarily know what an action produces until it is done.

We could fix this as a non-breaking change in V2, it will be a bit challenging, but possible, if needed (add a new outputs field, keep supporting all fields on the servers, stop type-checking the outputs on the servers, change the clients once servers add support for the new field).

But it will be much simpler to just change this in v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant