Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release merge_feature_manifest.par #69

Closed
mauriciogg opened this issue Jan 23, 2023 · 2 comments
Closed

Release merge_feature_manifest.par #69

mauriciogg opened this issue Jan 23, 2023 · 2 comments

Comments

@mauriciogg
Copy link
Contributor

Feature modules are broken due to merge_feature_manifest.par missing (https://github.com/bazelbuild/rules_android/blob/pre-alpha/rules/android_application/attrs.bzl#L62)

Can this be switched to the vanilla manifest merger? Other than having some special logic to insert ${MODULE_TITLE} in the manifest I can't tell what else it might be doing.
@nkoroste
Copy link
Contributor

@ahumesky @ted-xie what's special about that manifest merger? are you planning to upstream it?

copybara-service bot pushed a commit that referenced this issue May 4, 2023
@ted-xie
Open-source merge_feature_manifests.py
744528d 
Fixes issue #69.

PiperOrigin-RevId: 529538900
Change-Id: Ie368df7f77665e00bb651b745700f174fce98c2c
@ted-xie
Copy link
Contributor

ted-xie commented May 5, 2023

We've released this file: 744528d

@ted-xie ted-xie closed this as completed May 5, 2023
jylinv0 pushed a commit to jylinv0/rules_android that referenced this issue Jan 23, 2024
@ted-xie
Open-source merge_feature_manifests.py
3600cfb 
Fixes issue bazelbuild#69.

PiperOrigin-RevId: 529538900
Change-Id: Ie368df7f77665e00bb651b745700f174fce98c2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nkoroste @ted-xie @mauriciogg