Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skylib dependency #10

Closed
wants to merge 2 commits into from
Closed

Add skylib dependency #10

wants to merge 2 commits into from

Conversation

hlopko
Copy link
Member

@hlopko hlopko commented Mar 26, 2019

Skylib will be used to check minimum supported Bazel version.

scentini
scentini previously approved these changes Mar 26, 2019
View reviewed changes
@hlopko hlopko added type: feature request Request for new, generally useful functionality that is missing P1 Very important issue. Owner will work most of their time on fixing it. bazel 1.0 Issues that the team wants to fix before Bazel 1.0 labels Mar 27, 2019
bazel-io pushed a commit that referenced this pull request Mar 29, 2019
Add skylib dependency
951df6a 
[Copybara import of #10]

Skylib will be used to check minimum supported Bazel version.
Merge 2e5b5eb into 3723b4c

PiperOrigin-RevId: 240725578
oquenchil
oquenchil approved these changes Apr 16, 2019
View reviewed changes
Copy link
Collaborator

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlopko hlopko closed this May 16, 2019
@hlopko hlopko deleted the add_skylib branch May 22, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scentini scentini scentini approved these changes

@oquenchil oquenchil oquenchil approved these changes

Assignees
No one assigned
Labels
bazel 1.0 Issues that the team wants to fix before Bazel 1.0 cla: yes P1 Very important issue. Owner will work most of their time on fixing it. type: feature request Request for new, generally useful functionality that is missing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hlopko @scentini @oquenchil @googlebot