Fix new buildifer warnings #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related bazelbuild/bazel#15025 |
keith
force-pushed
the
ks/fix-new-buildifer-warnings
branch
from
7ce6042
to
2008b5e
Compare
keith
commented
Mar 11, 2022
| continue | ||
|
|
||
| found = True | ||
| for arg in reversed(action.argv): |
There was a problem hiding this comment.
@oquenchil I'm not sure if the order change here is important or not, but there are now different actions and index 1 didn't seem like what we wanted anymore
There was a problem hiding this comment.
Ahh, missed this. I thought this PR was just fixing formatting.
I will rewrite all these tests today not to rely on the index. I will get back to you.
This was referenced Mar 11, 2022
|
Looks like |
|
Thanks a lot! |
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 17, 2022
They are now part of the bazelbuild/bazel repository. Copies buildifier changes contributed by Keith in #128 RELNOTES:none PiperOrigin-RevId: 435312636 Change-Id: I4d5d2f58d90026c0cdfb5c0a90709de7c28c6ccd
|
Merged the changes you made here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.