Fix strict deps warning #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New version of turbine detects this as a layering violation (https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/515#f0057ef6-e13b-48f4-a7be-95488fcc52d6).
hlopko
added a commit
to bazelbuild/continuous-integration
that referenced
this pull request
Oct 19, 2018
But only until bazelbuild/rules_closure#286 is accepted.
hlopko
added a commit
to bazelbuild/continuous-integration
that referenced
this pull request
Oct 19, 2018
But only once bazelbuild/rules_closure#286 is merged and gerrit is updated to use rules_closure with the fix.
dslomov
approved these changes
Oct 19, 2018
hlopko
added a commit
to bazelbuild/continuous-integration
that referenced
this pull request
Oct 19, 2018
joeleba
pushed a commit
to joeleba/continuous-integration
that referenced
this pull request
Jun 17, 2019
But only until bazelbuild/rules_closure#286 is accepted.
joeleba
pushed a commit
to joeleba/continuous-integration
that referenced
this pull request
Jun 17, 2019
But only once bazelbuild/rules_closure#286 is merged and gerrit is updated to use rules_closure with the fix.
joeleba
pushed a commit
to joeleba/continuous-integration
that referenced
this pull request
Jun 17, 2019
ptmphuong
pushed a commit
to ptmphuong/rules_closure
that referenced
this pull request
Dec 9, 2022
New version of turbine detects this as a layering violation (https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/515#f0057ef6-e13b-48f4-a7be-95488fcc52d6).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of turbine detects this as a layering violation (https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/515#f0057ef6-e13b-48f4-a7be-95488fcc52d6).