nodejs_image node repository settings don't match current master of rules_nodejs

[psigen]

In the latest release and current master of rules_nodejs, there is not a bin/node_repo_args.sh, and the default name for the repository is suffixed with a platform, e.g. nodejs_linux_amd64:

• https://github.com/bazelbuild/rules_nodejs/blob/e4842c13c0ea16af1eb620c069d7e9116f566a1a/nodejs/repositories.bzl#L304
• Nodejs_image: build aborted: no such package '@nodejs//' #2016 (comment)

This seems to contradict the default arguments in the rules_docker nodejs_image rule currently:

rules_docker/nodejs/image.bzl

Lines 122 to 123 in 8f72908

	node_repository_name = "nodejs",
	include_node_repo_args = True,

Which means that we seem to need the following two options on every nodejs_image target to get them to compile:

nodejs_image(
    [...]
    include_node_repo_args = False,
    node_repository_name = "nodejs_linux_amd64",
)

Otherwise I see one of the following two errors:

ERROR: [...]/BUILD.bazel:30:13: no such package '@nodejs//': The repository '@nodejs' could not be resolved: Repository '@nodejs' is not defined and referenced by '//my_node_target:image.2'
ERROR: Analysis of target '//my_node_target:image' failed; build aborted: 

ERROR: [...]/BUILD.bazel:30:13: no such target '@nodejs_linux_amd64//:bin/node_repo_args.sh': target 'bin/node_repo_args.sh' not declared in package '' defined by [...]/.cache/bazel/_bazel_pras/2e5a3dfbf28c2d99ea1eb601cd4191f0/external/nodejs_linux_amd64/BUILD.bazel and referenced by '//my_node_target:image.2'

---

Versions I am testing with:

• rules_docker: https://github.com/bazelbuild/rules_docker/releases/tag/v0.24.0
• rules_nodejs: https://github.com/bazelbuild/rules_nodejs/releases/tag/5.4.2

[codersasha]

This issue was introduced in #1982.

[github-actions]

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

[github-actions]

This issue was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"