Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

README is ahead of release #597

Closed
chrislovecnm opened this issue Dec 4, 2018 · 1 comment · Fixed by #599
Closed

README is ahead of release #597

chrislovecnm opened this issue Dec 4, 2018 · 1 comment · Fixed by #599

Comments

@chrislovecnm
Copy link

The readme lists using

http_archive(
    name = "io_bazel_rules_docker",
    sha256 = "29d109605e0d6f9c892584f07275b8c9260803bf0c6fcb7de2623b2bedc910bd",
    strip_prefix = "rules_docker-0.5.1",
    urls = ["https://github.com/bazelbuild/rules_docker/archive/v0.5.1.tar.gz"],
)

# Call this to override the default docker toolchain configuration. This call
# should be placed BEFORE the call to "container_repositories" below to actually 
# override the default toolchain configuration
load("@io_bazel_rules_docker//toolchains/docker:toolchain.bzl",
    docker_toolchain_configure="toolchain_configure"
)
docker_toolchain_configure(name = "docker_config")

But this is incorrect. Version v0.5.1.tar.gz does not have the toolchain in it yet.

http_archive(
    name = "io_bazel_rules_docker",
    sha256 = "29d109605e0d6f9c892584f07275b8c9260803bf0c6fcb7de2623b2bedc910bd",
    strip_prefix = "rules_docker-0.5.1",
    urls = ["https://github.com/bazelbuild/rules_docker/archive/v0.5.1.tar.gz"],
)

load(
    "@io_bazel_rules_docker//container:container.bzl",
    "container_pull",
    container_repositories = "repositories",
)

container_repositories()

I believe is correct

/cc @nlopezgi

@nlopezgi
Copy link
Contributor

nlopezgi commented Dec 4, 2018

the latest release does not include the toolchain changes, please look at the state of README at the release for instructions for that release (https://github.com/bazelbuild/rules_docker/tree/v0.5.1)

@nlopezgi nlopezgi mentioned this issue Dec 4, 2018
nlopezgi added a commit that referenced this issue Dec 4, 2018
fix #597
fix #598
provide docs for recommended fix for #317
Improve documentation for xx_image rules to make more explicit that args such as env and symlinks will never be added to xx_image and container_image must be used in conjunction with xx_image for these use cases.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants