Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Add archive manipulation logic from rules_pkg #1556

Merged
merged 4 commits into from
Jul 14, 2020
Merged

Add archive manipulation logic from rules_pkg #1556

merged 4 commits into from
Jul 14, 2020

Conversation

alex1545
Copy link
Contributor

@alex1545 alex1545 commented Jul 14, 2020 •
edited

Addresses #1553

@alex1545 alex1545 requested a review from smukherj1 as a code owner July 14, 2020 06:24
@smukherj1
Copy link
Collaborator

/gcbrun

smukherj1
smukherj1 suggested changes Jul 14, 2020
View reviewed changes
Copy link
Collaborator

@smukherj1 smukherj1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, did not see the ImportError: No module named 'archive'

I think the error might be related to how relative imports are handled differently in python 3. I suggest trying from . import archive or import .archive

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 14, 2020
@alex1545
Copy link
Contributor Author

/gcbrun

@alex1545 alex1545 requested a review from smukherj1 July 14, 2020 15:23
@smukherj1 smukherj1 merged commit 2ae5f7f into bazelbuild:master Jul 14, 2020
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alex1545, smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alex1545 alex1545 deleted the move-archive branch July 14, 2020 16:11
@smukherj1 smukherj1 mentioned this pull request Aug 31, 2020
Closed
@mvukov mvukov mentioned this pull request May 27, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@smukherj1 smukherj1 smukherj1 approved these changes

Assignees

@smukherj1 smukherj1

Labels
approved cla: yes lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alex1545 @smukherj1 @k8s-ci-robot @googlebot