Add s390x support to load puller and loader binary #1661
Conversation
|
@alex1545 @smukherj1 Could you please have a look ? |
container/load.bzl
Outdated
| if repository_ctx.os.name.lower().startswith("mac os"): | ||
| loader = repository_ctx.attr._loader_darwin | ||
| arch = repository_ctx.execute(["uname", "-m"]).stdout.strip() |
There was a problem hiding this comment.
Unfortunately this will most likely break on Windows. Also given we don't have a Windows CI, it'll be hard to validate either way.
I think I want to stay away from having to maintain platform specific ways of detecting the architecture. Instead could you add a new attribute that defaults to amd64 but could be explicitly specified to be s390x?
There was a problem hiding this comment.
@smukherj1 Please review updated load.bzl and pull.bzl files.
srajmane
force-pushed
the
s390x_support
branch
from
9ed06ef
to
2e02e42
Compare
|
/gcbrun |
|
Actually buildkite CI is failing. Could you fix the formatting errors reported by buildifier? |
srajmane
force-pushed
the
s390x_support
branch
from
2e02e42
to
85c0cac
Compare
@smukherj1 Fixed formatting errors. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smukherj1, srajmane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/gcbrun |
No description provided.