Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

go_register_toolchains: set default version #1700

Closed
wants to merge 3 commits into from

Conversation

rgs1
Copy link

@rgs1 rgs1 commented Dec 17, 2020

The support for a default version in go_register_toolchains is gone, so
we need to pass an explicit version.

Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com

The support for a default version in go_register_toolchains is gone, so
we need to pass an explicit version.

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
@google-cla
Copy link

google-cla bot commented Dec 17, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rgs1
To complete the pull request process, please assign eytankidron after the PR has been reviewed.
You can assign the PR to them by writing /assign @eytankidron in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rgs1
Copy link
Author

rgs1 commented Dec 17, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 17, 2020
Raul Gutierrez Segales added 2 commits December 17, 2020 17:30
Fix
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
@rgs1
Copy link
Author

rgs1 commented Dec 21, 2020

Not really needed, see workaround here:

bazelbuild/rules_go#2761

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants