This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Fix tests resulting from pip dropping support for legacy Python #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n versions.
The tests are using a base image that only has python3.5 and currently the run_arbitrary tests are failing with
```
stderr: Traceback (most recent call last):
File "/usr/local/bin/pip", line 7, in <module>
from pip._internal.cli.main import main
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/cli/main.py", line 60
sys.stderr.write(f"ERROR: {exc}")
^
SyntaxError: invalid syntax
```
This was fixed upstream in pyenv/pyenv#1793 but it is not clear to me how/when we can expect to see that as part of launcher.gcr.io/google/bazel:latest.
faximan
requested review from
DaveGay,
eytankidron and
smukherj1
as code owners
|
/gcbrun |
smukherj1
approved these changes
Feb 2, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: faximan, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are using a base image that only has python3.5.
Currently the
//testing/examples/run_instruction_arbitrary:alltests are failing withThis was fixed upstream in pyenv/pyenv#1793 but it is not clear to me how/when we can expect to see that as part of launcher.gcr.io/google/bazel:latest.