Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Fixed some missing digests and addressed other warnings #1819

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Fixed some missing digests and addressed other warnings #1819

merged 1 commit into from
Apr 26, 2021

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Apr 25, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

When building these rules, there's currently a large list of warnings coming from various things within the workspace.

(23:38:49) DEBUG: Rule 'ubuntu1604' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "eb50020790e22538676e17c0242b9272bdb5c81f7bc6b128a4abfa7ad31faf5b"
(23:38:49) DEBUG: Repository ubuntu1604 instantiated at:
  /workdir/WORKSPACE:226:13: in <toplevel>
Repository rule http_archive defined at:
  /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
(23:38:49) DEBUG: Rule 'debian9' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "eb50020790e22538676e17c0242b9272bdb5c81f7bc6b128a4abfa7ad31faf5b"
(23:38:49) DEBUG: Repository debian9 instantiated at:
  /workdir/WORKSPACE:232:13: in <toplevel>
Repository rule http_archive defined at:
  /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
(23:38:49) DEBUG: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/npm/install_bazel_dependencies.bzl:5:14:
NOTICE: install_bazel_dependencies is no longer needed,
since @bazel/* npm packages can be load()ed without copying to another repository.
See https://github.com/bazelbuild/rules_nodejs/issues/1877
 
install_bazel_dependencies is harmful because it causes npm_install/yarn_install to run even
if the requested output artifacts for the build don't require nodejs, making multi-language monorepo
use cases slower.
 
You should be able to remove install_bazel_workspaces from your WORKSPACE file unless you depend
on a package that exposes a separate repository, like @angular/bazel exposes @npm_angular_bazel//:index.bzl
 
You can suppress this message by passing "suppress_warning = True" to install_bazel_dependencies()
(23:38:49) DEBUG: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/bazel_toolchains/rules/rbe_repo/version_check.bzl:68:14:
Current running Bazel is ahead of bazel-toolchains repo. Please update your pin to bazel-toolchains repo in your WORKSPACE file.
(23:38:49) DEBUG: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/bazel_toolchains/rules/rbe_repo/checked_in.bzl:125:14: buildkite_config not using checked in configs; Bazel version 4.0.0 was picked/selected but no checked in config was found in map {"0.20.0": ["8.0.0"], "0.21.0": ["8.0.0"], "0.22.0": ["8.0.0", "9.0.0"], "0.23.0": ["8.0.0", "9.0.0"], "0.23.1": ["8.0.0", "9.0.0"], "0.23.2": ["9.0.0"], "0.24.0": ["9.0.0"], "0.24.1": ["9.0.0"], "0.25.0": ["9.0.0"], "0.25.1": ["9.0.0"], "0.25.2": ["9.0.0"], "0.26.0": ["9.0.0"], "0.26.1": ["9.0.0"], "0.27.0": ["9.0.0"], "0.27.1": ["9.0.0"], "0.28.0": ["9.0.0"], "0.28.1": ["9.0.0"], "0.29.0": ["9.0.0"], "0.29.1": ["9.0.0", "10.0.0"], "1.0.0": ["9.0.0", "10.0.0"], "1.0.1": ["10.0.0"], "1.1.0": ["10.0.0"], "1.2.0": ["10.0.0"], "1.2.1": ["10.0.0"], "2.0.0": ["10.0.0"], "2.1.0": ["10.0.0"], "2.1.1": ["10.0.0", "11.0.0"], "2.2.0": ["11.0.0"], "3.0.0": ["11.0.0"], "3.1.0": ["11.0.0"], "3.2.0": ["11.0.0"], "3.3.0": ["11.0.0"], "3.3.1": ["11.0.0"], "3.4.1": ["11.0.0"], "3.5.0": ["11.0.0"]}
(23:38:50) DEBUG: Rule 'k8s_pause_arm64' indicated that a canonical reproducible form can be obtained by modifying arguments digest = "sha256:f365626a556e58189fc21d099fc64603db0f440bff07f77c740989515c544a39"
(23:38:50) DEBUG: Repository k8s_pause_arm64 instantiated at:
  /workdir/WORKSPACE:149:15: in <toplevel>
Repository rule container_pull defined at:
  /workdir/container/pull.bzl:243:33: in <toplevel>
(23:38:51) DEBUG: Rule 'alpine_linux_armv6_tar' indicated that a canonical reproducible form can be obtained by modifying arguments digest = "sha256:dabea2944dcc2b86482b4f0b0fb62da80e0673e900c46c0e03b45919881a5d84"
(23:38:51) DEBUG: Repository alpine_linux_armv6_tar instantiated at:
  /workdir/WORKSPACE:61:15: in <toplevel>
Repository rule container_pull defined at:
  /workdir/container/pull.bzl:243:33: in <toplevel>
(23:38:53) DEBUG: Rule 'alpine_linux_ppc64le' indicated that a canonical reproducible form can be obtained by modifying arguments digest = "sha256:402d21757a03a114d273bbe372fa4b9eca567e8b6c332fa7ebf982b902207242"
(23:38:53) DEBUG: Repository alpine_linux_ppc64le instantiated at:
  /workdir/WORKSPACE:141:15: in <toplevel>
Repository rule container_pull defined at:
  /workdir/container/pull.bzl:243:33: in <toplevel>
(23:38:54) DEBUG: Rule 'alpine_linux_amd64' indicated that a canonical reproducible form can be obtained by modifying arguments digest = "sha256:954b378c375d852eb3c63ab88978f640b4348b01c1b3456a024a81536dafbbf4"
(23:38:54) DEBUG: Repository alpine_linux_amd64 instantiated at:
  /workdir/WORKSPACE:124:15: in <toplevel>
Repository rule container_pull defined at:
  /workdir/container/pull.bzl:243:33: in <toplevel>
(23:38:54) DEBUG: Rule 'distroless_base' indicated that a canonical reproducible form can be obtained by modifying arguments digest = "sha256:75f63d4edd703030d4312dc7528a349ca34d48bec7bd754652b2d47e5a0b7873"
(23:38:54) DEBUG: Repository distroless_base instantiated at:
  /workdir/WORKSPACE:93:15: in <toplevel>
Repository rule container_pull defined at:
  /workdir/container/pull.bzl:243:33: in <toplevel>
(23:38:57) DEBUG: Rule 'distroless_cc' indicated that a canonical reproducible form can be obtained by modifying arguments digest = "sha256:c33fbcd3f924892f2177792bebc11f7a7e88ccbc247f0d0a01a812692259503a"
(23:38:57) DEBUG: Repository distroless_cc instantiated at:
  /workdir/WORKSPACE:99:15: in <toplevel>
Repository rule container_pull defined at:
  /workdir/container/pull.bzl:243:33: in <toplevel>

These should be addressed to improve caching and avoid potential future breakages.

What is the new behavior?

The issues above have been addressed

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Apr 25, 2021
@UebelAndre UebelAndre marked this pull request as ready for review April 25, 2021 23:53
@alexeagle alexeagle merged commit 2ece6df into bazelbuild:master Apr 26, 2021
@UebelAndre UebelAndre deleted the cleanup branch April 26, 2021 01:55
martaver pushed a commit to cleric-sh/rules_docker that referenced this pull request May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants