Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Propagate tags to app-layers in docker images for all langs #1836

Merged
merged 1 commit into from
May 1, 2021

Conversation

vsbus
Copy link
Contributor

@vsbus vsbus commented Apr 30, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

We are using py3_image() with layers parameter in one of our projects. These images have tags = ["manual"] so we don't expect them to build with bazel build //.... However, we observing that .tar files with layers are still built. That happened because tags were not propagated to the layer's targets. This PR is trying to fix the issue.

Issue Number: N/A

What is the new behavior?

bazel build //... doesn't build extra targets like layers when manual tag is used.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Apr 30, 2021
@vsbus vsbus changed the title fix-tags Propagate tags to app-layers in docker images for all langs Apr 30, 2021
@vsbus vsbus mentioned this pull request Apr 30, 2021
12 tasks
@vsbus
Copy link
Contributor Author

vsbus commented Apr 30, 2021

Hey @gravypod , please take another look

Copy link
Collaborator

@gravypod gravypod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Lets just get a second review from @alexeagle since this will be a user-visible change.

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle alexeagle merged commit 2a8565c into bazelbuild:master May 1, 2021
martaver pushed a commit to cleric-sh/rules_docker that referenced this pull request May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants