This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Update to a more recent rules rust and update to use defs.bzl #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rules rust has made some changes upstream that remove the rust.bzl file. It had previously been left in there for compatibility purposes. This has been ongoing since February 16th. See this issue for additional context: bazelbuild/rules_rust#591.
dfreese
requested review from
alexeagle,
gravypod,
pcj and
smukherj1
as code owners
10 tasks
|
@gravypod this should be good-to-go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules rust has made some changes upstream that remove the rust.bzl file.
It had previously been left in there for compatibility purposes. This
has been ongoing since February 16th. See this issue for additional
context: bazelbuild/rules_rust#591. Replaces
PRs #1950 and #1951.
Fixes #1949
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?