Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

feat(): allow rules_docker to work with rules_nodejs 5.x when it updates #1982

Merged
merged 1 commit into from
Dec 16, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions nodejs/image.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ def nodejs_image(
binary = None,
launcher = None,
launcher_args = None,
node_repository_name = "nodejs",
include_node_repo_args = True,
**kwargs):
"""Constructs a container image wrapping a nodejs_binary target.

Expand All @@ -142,11 +144,13 @@ def nodejs_image(

nodejs_layers = [
# Put the Node binary into its own layers.
"@nodejs//:node",
"@nodejs//:node_files",
"@nodejs//:bin/node_repo_args.sh",
"@%s//:node" % node_repository_name,
"@%s//:node_files" % node_repository_name,
]

if include_node_repo_args:
nodejs_layers.append("@%s//:bin/node_repo_args.sh" % node_repository_name)

all_layers = nodejs_layers + layers

visibility = kwargs.get("visibility", None)
Expand Down