This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Changing docker client config attributes to Bazel labels #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzhp
requested review from
smukherj1,
alexeagle,
pcj and
gravypod
as code owners
uhthomas
reviewed
Apr 15, 2022
There was a problem hiding this comment.
The PR and logic itself seems sound to me, I don't see any use-cases where an absolute path would be desirable. Despite this, it should still possible for the toolchain to use the client config specified in the home directory, or with the DOCKER_CONFIG environment variable.|
Pending response to the comments I left, I'm happy to approve this.
uhthomas
approved these changes
Apr 15, 2022
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2040
What is the new behavior?
toolchain_configureonly takes a Bazel labelDoes this PR introduce a breaking change?
Existing applications will have to change the
client_configof theirtoolchain_configurerule to be a Bazel label.Other information
This is more correct than #2032 and #2041, but it introduces a breaking change.