Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change cygpath to mixed #1091

Closed
wants to merge 1 commit into from
Closed

change cygpath to mixed #1091

wants to merge 1 commit into from

Conversation

matt-sm
Copy link
Contributor

@matt-sm matt-sm commented Sep 7, 2023

cygpath -w will print \ eg. c:\Users\msmith.

When this is used to calculate EXT_BUILD_ROOT, and EXT_BUILD_ROOT is used as a suffix for other paths, it can lead to a mix of \ amd / which can cause configure_make build failures. eg.

unsafe srcdir value: 'C:\tmp\2b4dntvp\execroot\__main__/external/

cygpath comes preinstalled in msys2, therefore is always used to calculate pwd.

The fallback, pwd -W will print / eg. c:/Users/msmith.

This MR changes the Windows pwd() to use the cygpath -m "mixed" mode that matches pwd -W.

@google-cla
Copy link

google-cla bot commented Sep 7, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@matt-sm
Copy link
Contributor Author

matt-sm commented Sep 7, 2023

It appears meson prefers c:\..\ paths.

Program win_flex found: YES (C:\tmp\766s67rb\execroot\rules_foreign_cc_examples\bazel-out\x64_windows-opt-exec-2B5CBBC6-ST-2324745666c0\bin\external\winflexbison\copy_winflexbison\winflexbison\win_flex.EXE)

when c:\..\.. in PATH vs

Program win_flex found: NO

when c:/../ in PATH

I noticed those tool paths are in the build script but I'm not sure how they're being inserted.

@jsharpe
Copy link
Collaborator

jsharpe commented May 29, 2024

Closing in favour of #1204

@jsharpe jsharpe closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants