Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix replace_in_files for file names with spaces #923

Merged
merged 2 commits into from
Jun 19, 2022

Conversation

george-enf
Copy link
Contributor

Define files variable as an array and quote it when accessing it to
support file names with spaces.

Signed-off-by: George Prekas george@enfabrica.net

Define files variable as an array and quote it when accessing it to
support file names with spaces.

Signed-off-by: George Prekas <george@enfabrica.net>
@george-enf george-enf force-pushed the fix-replace-in-files-spaces branch from 5dc833b to 9ab2571 Compare June 3, 2022 19:01
Copy link
Collaborator

@jsharpe jsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@jsharpe jsharpe enabled auto-merge (squash) June 19, 2022 13:14
@jsharpe jsharpe merged commit b1e65fe into bazelbuild:main Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants