Faciliate usage of jom #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jom tool (a fork of nmake which supports parallel builds) does not support the "-C <dir>" arg. Given that the build script generated by rules_foreign_cc changes the working directory to $BUILD_TMPDIR before invoking make/nmake/jom, there is no need to add the "-C $BUILD_TMPDIR" arg. This commit removes the addition of the "-C $BUILD_TMPDIR" arg so that jom can be used as a make variant.
jsharpe
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jom tool (a fork of nmake which supports parallel builds) does not
support the "-C dir" arg. Given that the build script generated by
rules_foreign_cc changes the working directory to $BUILD_TMPDIR before
invoking make/nmake/jom, there is no need to add the "-C $BUILD_TMPDIR"
arg. This commit removes the addition of the "-C $BUILD_TMPDIR" arg so
that jom can be used as a make variant.