Correctly forward InstrumentedFilesInfo from dependencies (#3294)

This is required with coverage_output_generator v2.6 used by Bazel@HEAD, which filters LCOV files to contain only those source mentioned in the provider.
bazelbuild · Sep 14, 2022 · ba48db5 · ba48db5
1 parent fc2afba
commit ba48db5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/go/private/rules/library.bzl b/go/private/rules/library.bzl
@@ -52,6 +52,12 @@ def _go_library_impl(ctx):
         DefaultInfo(
             files = depset([archive.data.file]),
         ),
+        coverage_common.instrumented_files_info(
+            ctx,
+            source_attributes = ["srcs"],
+            dependency_attributes = ["data", "deps", "embed", "embedsrcs"],
+            extensions = ["go"],
+        ),
         OutputGroupInfo(
             cgo_exports = archive.cgo_exports,
             compilation_outputs = [archive.data.file],

diff --git a/go/private/rules/test.bzl b/go/private/rules/test.bzl
@@ -181,7 +181,7 @@ def _go_test_impl(ctx):
         coverage_common.instrumented_files_info(
             ctx,
             source_attributes = ["srcs"],
-            dependency_attributes = ["deps", "embed"],
+            dependency_attributes = ["data", "deps", "embed", "embedsrcs"],
             extensions = ["go"],
         ),
         testing.TestEnvironment(env),