Skip to content

Commit

Permalink
new_library: remove unused resolver (#3219)
Browse files Browse the repository at this point in the history
`_testmain_library_to_source` was introduced in 1c4f6fd and last usage
of this resolver was in 56e5592.

  ```
  > git log -S'_testmain_library_to_source' --oneline
  56e5592 Move the test library rule to be go_test internal actions (#1267)
  9031d58 Add GoContext (#1140)
  1c4f6fd Fix aspect based proto builds (#1131)
  ```

Let's remove the unused resolver and replace the documentation with the
resolver that is actually being used.
  • Loading branch information
sluongng committed Jul 17, 2022
1 parent 54c6b9d commit ed56d7e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions go/private/rules/test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@ load(
"structs",
)

def _testmain_library_to_source(go, attr, source, merge):
source["deps"] = source["deps"] + [attr.library]

def _go_test_impl(ctx):
"""go_test_impl implements go testing.
Expand Down
2 changes: 1 addition & 1 deletion go/toolchains.rst
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@ resolver when it is invoked.
| |
| .. code:: bzl |
| |
| def _testmain_library_to_source(go, attr, source, merge) |
| def _stdlib_library_to_source(go, attr, source, merge) |
| |
| attr is the attributes of the rule being processed |
| source is the dictionary of GoSource fields being generated |
Expand Down

0 comments on commit ed56d7e

Please sign in to comment.