Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gazelle generates incorrect dependencies for gopkg.in/src-d/go-git.v4 #1188

Closed
jeremyje opened this issue Dec 27, 2017 · 2 comments
Closed

Comments

@jeremyje
Copy link

jeremyje commented Dec 27, 2017

If you have a golang project that depends on gopkg.in/src-d/go-git.v4 then gazelle generates deps with @in_gopkg_src_d//go-git.v4:go_default_library instead.

This is especially problematic when the deps of deps use gopkg.in since those rules are autogenerated.

Lastly, it's kinda weird why these commits are pinned why gazelle can't just infer the go_repositories altogether.

@jayconrod
Copy link
Contributor

If you have a golang project that depends on gopkg.in/src-d/go-git.v4 then gazelle generates deps with @in_gopkg_src_d//go-git.v4:go_default_library instead.

I remember this being an issue some time ago, but I believe it's been fixed. What commit are you using for Gazelle? When I use Gazelle at tip, that path resolves to @in_gopkg_src_d_go_git_v4//:go_default_library.

Lastly, it's kinda weird why these commits are pinned why gazelle can't just infer the go_repositories altogether.

bazelbuild/bazel-gazelle#56 is the general issue tracking this. It will take some time though.

@jeremyje
Copy link
Author

Closing. I upgraded gazelle and the problem went away. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants