Use a more unique name for the cover variable #1764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kubernetes, we get a build failure when running
bazel coverage
:The root cause appears to be at least partially self-inflicted; we have a
pkg/kubelet/container/os.go
file (in packagecontainer
), and apkg/kubelet/container/testing/os.go
file (in packagetesting
).The existing
rules_go
coverage generator creates aCover_os
variable in each package, which would be unique, except thatpkg/kubelet/container/testing/runtime_mock.go
dot-importspkg/kubelet/container
, causing the conflict.I've attempted to fix the issue here by just including the package path in the variable name, e.g.
Cover_k8s_io_kubernetes_pkg_kubelet_container_os
instead ofCover_os
. This seems to work, though I'm not sure if there are corner cases I'm missing.