lcov_merger: workaround for Bazel 0.18.0 coverage #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When collecting coverage, Bazel now expects test rules to have an implicit "$lcov_merger" or "_lcov_merger" attribute that points to a binary to be run by the test driver script. This change adds a dummy _lcov_merger attribute to go_test. The script does nothing for now. Related bazelbuild/bazel#6293
jayconrod
force-pushed
the
fix-coverage
branch
from
593d269
to
28037bd
Compare
jayconrod
added a commit
that referenced
this pull request
Oct 16, 2018
When collecting coverage, Bazel now expects test rules to have an implicit "$lcov_merger" or "_lcov_merger" attribute that points to a binary to be run by the test driver script. This change adds a dummy _lcov_merger attribute to go_test. The script does nothing for now. Related bazelbuild/bazel#6293
jayconrod
added a commit
that referenced
this pull request
Oct 16, 2018
When collecting coverage, Bazel now expects test rules to have an implicit "$lcov_merger" or "_lcov_merger" attribute that points to a binary to be run by the test driver script. This change adds a dummy _lcov_merger attribute to go_test. The script does nothing for now. Related bazelbuild/bazel#6293
jayconrod
added a commit
that referenced
this pull request
Oct 16, 2018
When collecting coverage, Bazel now expects test rules to have an implicit "$lcov_merger" or "_lcov_merger" attribute that points to a binary to be run by the test driver script. This change adds a dummy _lcov_merger attribute to go_test. The script does nothing for now. Related bazelbuild/bazel#6293
jayconrod
added a commit
that referenced
this pull request
Oct 16, 2018
When collecting coverage, Bazel now expects test rules to have an implicit "$lcov_merger" or "_lcov_merger" attribute that points to a binary to be run by the test driver script. This change adds a dummy _lcov_merger attribute to go_test. The script does nothing for now. Related bazelbuild/bazel#6293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When collecting coverage, Bazel now expects test rules to have an
implicit "$lcov_merger" or "_lcov_merger" attribute that points to a
binary to be run by the test driver script.
This change adds a dummy _lcov_merger attribute to go_test. The script
does nothing for now.
Related bazelbuild/bazel#6293