Migrate to cc_common for collecting C/C++ paths and options #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the internal go_context_data read C/C++ paths and options from the CcToolchainInfo provider. Most of the fields in this provider come from CROSSTOOL and will be removed in Bazel 0.20.0 (see https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api). This change migrates us to use the new cc_common module. This change is intended to be a quick fix to be backported to old release branches, so no architectural changes are made. Fixes bazelbuild#1744 Related bazelbuild#1742
jayconrod
force-pushed
the
cgo-compatibility
branch
from
0d1a257
to
bb8c64b
Compare
jayconrod
force-pushed
the
cgo-compatibility
branch
from
bb8c64b
to
eb078b6
Compare
jayconrod
added a commit
that referenced
this pull request
Oct 16, 2018
Previously, the internal go_context_data read C/C++ paths and options from the CcToolchainInfo provider. Most of the fields in this provider come from CROSSTOOL and will be removed in Bazel 0.20.0 (see https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api). This change migrates us to use the new cc_common module. This change is intended to be a quick fix to be backported to old release branches, so no architectural changes are made. Fixes #1744 Related #1742
jayconrod
added a commit
that referenced
this pull request
Oct 16, 2018
Previously, the internal go_context_data read C/C++ paths and options from the CcToolchainInfo provider. Most of the fields in this provider come from CROSSTOOL and will be removed in Bazel 0.20.0 (see https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api). This change migrates us to use the new cc_common module. This change is intended to be a quick fix to be backported to old release branches, so no architectural changes are made. Fixes #1744 Related #1742
jayconrod
added a commit
that referenced
this pull request
Oct 16, 2018
Previously, the internal go_context_data read C/C++ paths and options from the CcToolchainInfo provider. Most of the fields in this provider come from CROSSTOOL and will be removed in Bazel 0.20.0 (see https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api). This change migrates us to use the new cc_common module. This change is intended to be a quick fix to be backported to old release branches, so no architectural changes are made. Fixes #1744 Related #1742
jayconrod
added a commit
that referenced
this pull request
Oct 16, 2018
Previously, the internal go_context_data read C/C++ paths and options from the CcToolchainInfo provider. Most of the fields in this provider come from CROSSTOOL and will be removed in Bazel 0.20.0 (see https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api). This change migrates us to use the new cc_common module. This change is intended to be a quick fix to be backported to old release branches, so no architectural changes are made. Fixes #1744 Related #1742
jayconrod
added a commit
that referenced
this pull request
Oct 16, 2018
Previously, the internal go_context_data read C/C++ paths and options from the CcToolchainInfo provider. Most of the fields in this provider come from CROSSTOOL and will be removed in Bazel 0.20.0 (see https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api). This change migrates us to use the new cc_common module. This change is intended to be a quick fix to be backported to old release branches, so no architectural changes are made. Fixes #1744 Related #1742
jayconrod
added a commit
that referenced
this pull request
Oct 16, 2018
Previously, the internal go_context_data read C/C++ paths and options from the CcToolchainInfo provider. Most of the fields in this provider come from CROSSTOOL and will be removed in Bazel 0.20.0 (see https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api). This change migrates us to use the new cc_common module. This change is intended to be a quick fix to be backported to old release branches, so no architectural changes are made. Fixes #1744 Related #1742
jayconrod
added a commit
that referenced
this pull request
Oct 16, 2018
Previously, the internal go_context_data read C/C++ paths and options from the CcToolchainInfo provider. Most of the fields in this provider come from CROSSTOOL and will be removed in Bazel 0.20.0 (see https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api). This change migrates us to use the new cc_common module. This change is intended to be a quick fix to be backported to old release branches, so no architectural changes are made. Fixes #1744 Related #1742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the internal go_context_data read C/C++ paths and options
from the CcToolchainInfo provider. Most of the fields in this provider
come from CROSSTOOL and will be removed in Bazel 0.20.0 (see
https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api).
This change migrates us to use the new cc_common module. This change
is intended to be a quick fix to be backported to old release
branches, so no architectural changes are made.
Fixes #1744
Related #1742