go/tools/builders/pack: preserve file extensions #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .a format limits file names to 16 characters. There are various extensions to this format which support longer names, but Go doesn't recognize them and generally doesn't need them. Before Go 1.12, the linker passed all extra files (other than the compiled Go code and the export data) to the external link. In Go 1.12, the linker only passes on .o files. The GoPack action simply truncated long file names, which meant .o files were sometimes ignored. GoPack will now preserve file extensions. Updates bazelbuild#1896
|
Spurious test failure will be fixed by #1902. |
jayconrod
added a commit
that referenced
this pull request
Jan 19, 2019
The .a format limits file names to 16 characters. There are various extensions to this format which support longer names, but Go doesn't recognize them and generally doesn't need them. Before Go 1.12, the linker passed all extra files (other than the compiled Go code and the export data) to the external link. In Go 1.12, the linker only passes on .o files. The GoPack action simply truncated long file names, which meant .o files were sometimes ignored. GoPack will now preserve file extensions. Updates #1896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .a format limits file names to 16 characters. There are various
extensions to this format which support longer names, but Go doesn't
recognize them and generally doesn't need them. Before Go 1.12, the
linker passed all extra files (other than the compiled Go code and the
export data) to the external link.
In Go 1.12, the linker only passes on .o files. The GoPack action
simply truncated long file names, which meant .o files were sometimes
ignored. GoPack will now preserve file extensions.
Updates #1896