Add minimal support for ARM64 on macOS. #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still fails several tests that assume x86-64, but it’s at least a starting point.
jayconrod
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
Looks good. Thanks for sending this.
I have very limited access to arm64 hardware, and we don't have any systems in CI yet, so I can't verify this. Also, my understanding is that uname -m may return x86_64 when invoked from an x86_64 process. Not sure whether Bazel runs as x86_64, but something to be aware of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still fails several tests that assume x86-64, but it’s at least a starting
point.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This implements basic support for ARM64 macOS systems.
Which issues(s) does this PR fix?
#2795
(This doesn't entirely fix the issue since some of the tests still fail)
Other notes for review