Ensure command line linkopts are added to cgo link flags #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rules_go seems to be ignoring --linkopt (and --copt/--cxxopt) when resolving command line flags. These flags are accessible through the "cpp" fragment and are not expanded by get_memory_inefficient_command_line as they are not part of the toolchain.
steeve
approved these changes
Aug 21, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
the cgo flag collection logic does not account for --linkopt configuration flag set for
rules_cc. These flags are appended post-toolchain flags in bazel and are not expanded as part of the toolchain logic.this PR appends these flags (accessible via the
cppfragment) to the options for the executable and shared library linking options.Which issues(s) does this PR fix?
Fixes #2923
Other notes for review