Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting versioned dylib in has_versioned_shared_lib_extension #2947

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Sep 1, 2021

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?
This is probably needed to fix #2944, but it's not enough. With this PR, versioned dylib becomes a build error instead of a runtime error.

Other notes for review

@steeve
Copy link
Contributor

steeve commented Sep 2, 2021

could you check also for xxx.1.2.3.dylib ? it seems those are in the wild too

@linzhp
Copy link
Contributor Author

linzhp commented Sep 2, 2021

xxx.1.2.3.dylib falls into this case, so they should work

Copy link
Contributor

@steeve steeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@steeve steeve merged commit f93f505 into bazelbuild:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioned Darwin dylib not working after 0.26
2 participants