Trim absolute paths in files generated by cgo #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
fix-cgo-sandbox-path-leakage
branch
2 times, most recently
from
5d8c43e
to
09f4495
Compare
The cgo command generates .c files that contain //line comments referencing source files by absolute paths into the Bazel cache. As the contents of these comments end up in the symbol table of the resulting c-archive, this makes Bazel-built CGo binaries non-reproducible. This is fixed by passing the -trimpath argument to cgo to trim the Bazel execroot prefix from these paths. Fixes bazelbuild#3010.
fmeum
force-pushed
the
fix-cgo-sandbox-path-leakage
branch
from
09f4495
to
cc86e36
Compare
|
Thank you! |
|
I wonder if this is also the fix for #3048 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
The cgo command generates .c files that contain //line comments
referencing source files by absolute paths into the Bazel cache. As the
contents of these comments end up in the symbol table of the resulting
c-archive, this makes Bazel-built CGo binaries non-reproducible.
This is fixed by passing the -trimpath argument to cgo to trim the
Bazel execroot prefix from these paths.
Which issues(s) does this PR fix?
Fixes #3010