builders/gentestmain: register correct cover mode in the coverage report file when enabling race mode #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem. It's not critic, take a look when you can. |
linzhp
reviewed
Nov 29, 2021
linzhp
reviewed
Nov 29, 2021
…ort file when enabling race mode Fixes #3018
linzhp
reviewed
Nov 30, 2021
| Blocks: map[string][]testing.CoverBlock{}, | ||
| } | ||
| // Contains all coverage data for the program. | ||
| var ( |
There was a problem hiding this comment.
I am not sure if this change is necessary. Can you keep Cover as testing.Cover without setting Mode and CoveredPackages? You can set coverdata.Cover.Mode in generate_test_main.go
There was a problem hiding this comment.
It's not necessary, but preferred IMHO, to avoid to manipulate an incomplete object which could be a source of mistake, even more when the object is exported in another package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Fix the cover mode to "atomic" in the coverage data file when the race detector is used.
Which issues(s) does this PR fix?
Fixes #3018