Update x/tools repository to v0.1.8 #3030 #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran the following commands: bazel build go/tools/releaser sed -i /org_golang_x_tools-public-visibility.patch/d go/private/repositories.bzl rm third_party/org_golang_x_tools-public-visibility.patch bazel-bin/go/tools/releaser/releaser_/releaser upgrade-dep org_golang_x_tools
robfig
approved these changes
Dec 16, 2021
| patches = [ | ||
| # deletegopls removes the gopls subdirectory. It contains a nested | ||
| # module with additional dependencies. It's not needed by rules_go. | ||
| # releaser:patch-cmd rm -rf gopls | ||
| "@io_bazel_rules_go//third_party:org_golang_x_tools-deletegopls.patch", | ||
| # releaser:patch-cmd gazelle -repo_root . -go_prefix golang.org/x/tools -go_naming_convention import_alias | ||
| "@io_bazel_rules_go//third_party:org_golang_x_tools-gazelle.patch", | ||
| "@io_bazel_rules_go//third_party:org_golang_x_tools-public-visibility.patch", |
There was a problem hiding this comment.
Confirmed that this patch is no longer necessary when using Gazelle 0.24 due to hard-coded support added in gazelle's commit 3ea1d64d6fe943dac06c341f9a265472bb99acd7
At first I was worried about unnecessarily increasing the minimum required version of Gazelle, but it looks like there is already a compatibility requirement, referring to:
https://github.com/bazelbuild/bazel-gazelle#compatibility-with-rules_go
|
Perfect! Thanks a lot for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran the following commands:
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Updates x/tools repository dependency to 0.1.8, which is needed to support new export format version emitted by Go 1.18.
Which issues(s) does this PR fix?
Fixes #3030
Other notes for review
n/a