map bazel's --test_runner_fail_fast to go's -failfast #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following are now equivalent ```sh > bazel test --test_runner_fail_fast //path/to/my/go/test > bazel test --test_arg=-failfast //path/to/my/go/test ```
achew22
approved these changes
Jan 24, 2022
|
I'm not sure if we cut the 0.30 release yet (that might have happened this morning), but it will either make it in 0.30 or 0.31. Thank you so much for such a quick and thorough PR! |
|
thanks for the quick review and pointing me in the right direction 👍 . Following the example of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
The following are now equivalent
Which issues(s) does this PR fix?
Fixes #3055
Other notes for review