Reducing duplicate information passed by go_pkg_info_aspect #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR consolidates two sets of data (
transitive_*anddeps_transitive_*) inGoPkgInfointo one set, and letdepsetto perform necessary deduplication. It also takes the approach proposed by @skevy in #3053 (comment) to remove the duplicate JSON files written bygo_pkg_info_aspectforgo_test.The test fixture was taken from https://github.com/csstaub/gopackagesdriver-repro, credits to @csstaub
Which issues(s) does this PR fix?
Fixes #2948
Other notes for review
@aignas FYI