Don't include non-executable go_binary in dependent's runfiles #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
non-executable
branch
3 times, most recently
from
c84510b
to
348265f
Compare
|
I had to work around a Bazel bug, but will not make any more changes now. |
fmeum
force-pushed
the
non-executable
branch
4 times, most recently
from
c3f1349
to
1a75eac
Compare
|
The CI failure might be due to bazelbuild/bazel#10254. I will wait for feedback on that issue. |
fmeum
force-pushed
the
non-executable
branch
2 times, most recently
from
8f46eed
to
0c9a414
Compare
Based on bazelbuild/bazel#10254 (comment) and bazelbuild/bazel#12304 being fixed, this special handling of rpaths on macOS appears to be unnecessary. This cleanup ensures that Bazel sets the correct metadata for the exec location of Go libraries linked in c-shared mode, which in turn allows to not include them in the runfiles of all dependents - cc_* targets depending on them will now generate the correct rpath entries to find the libraries at runtime at the usual position.
If a go_binary is built with a non-executable link mode such as `c-archive`, its dependents currently pick up a runfile dependency on it since its DefaultInfo specifies the resulting archive as an executable. This is unnecessary as the dependent should be able to decide whether to include the file (e.g. dynamic linking) or not (e.g. static linking). With this commit, the executable field of the DefaultInfo is only populated if the go_binary is built with an executable link mode. Follow-up to bazelbuild#3143
|
@achew22 @linzhp I don't know much about the macOS linker, but bazelbuild/bazel#10254 (comment) gave me confidence to try deleting the special casing that previously broke my PR. All tests pass with the custom logic removed, but please run this by someone who can confirm it's safe. |
kmicklas
approved these changes
Jun 9, 2022
|
@kmicklas did you already tested it in Uber? |
gcf-merge-on-green bot
pushed a commit
to googleapis/gapic-generator-go
that referenced
this pull request
Jul 19, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.33.0` -> `v0.34.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go</summary> ### [`v0.34.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.34.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.33.0...v0.34.0) #### What's Changed - releaser: fix scrubbing timestamp from patch files by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3180 - Replace Starlark JSON parser with json.decode by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3184 - gopackagesdriver: separates "s" files in pkg info by [@​iamricard](https://togithub.com/iamricard) in [bazelbuild/rules_go#3165 - Refactor away references to @​io_bazel_rules_go by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3185 - Do not print to stderr if cgo linking succeeds after retry by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3187 - Use param files with go-protoc by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3190 - Don't include non-executable go_binary in dependent's runfiles by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3151 - Link in native libraries of transitive dependencies in archive mode by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3186 - runfiles: remove deprecated api by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3198 - Fix failing open hermeticity test by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3206 - Fix go_googleapis Gazelle patch by [@​nickgooding](https://togithub.com/nickgooding) in [bazelbuild/rules_go#3193 - Exclude unsupported C/C++ features by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3189 - Allow gomock to take Bazel common attributes by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/rules_go#3207 - Transition on edges not self by [@​illicitonion](https://togithub.com/illicitonion) in [bazelbuild/rules_go#3116 - Include go_transition_test in bazel aspect by [@​ian-h-chamberlain](https://togithub.com/ian-h-chamberlain) in [bazelbuild/rules_go#3160 - Add an example for go_download_sdk.sdks by [@​fishy](https://togithub.com/fishy) in [bazelbuild/rules_go#3139 - tests: nogo over generated code by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3214 - test nogo/coverage: test generated code by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3213 - Remove references to go_transition_test by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/rules_go#3215 - Basic bzlmod setup by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3047 - Run BCR tests against Bazel 6.0.0-pre.20220608.2 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3223 - Use repo-relative labels in MODULE.bazel by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3226 - upkeep: upgrade to go 1.18.3 and gazelle v0.26.0 by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3220 - nogo: ignore generated source files by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3216 - asm: Pass package path with -p by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3231 - bzlmod: Add support for gomock by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3232 - test cgo: ensure helper script works by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3236 - Fix //tests/legacy/examples/cgo:cgo_lib_test on M1 Macs by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3237 - gopackagesdriver: Descend into go_proto_compiler's deps by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3240 - new_library: remove unused resolver by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3219 - nogo: instantiate type info for generic types when running under Go >=1.18 by [@​farhaven](https://togithub.com/farhaven) in [bazelbuild/rules_go#3212 #### New Contributors - [@​iamricard](https://togithub.com/iamricard) made their first contribution in [bazelbuild/rules_go#3165 - [@​ian-h-chamberlain](https://togithub.com/ian-h-chamberlain) made their first contribution in [bazelbuild/rules_go#3160 - [@​fishy](https://togithub.com/fishy) made their first contribution in [bazelbuild/rules_go#3139 - [@​farhaven](https://togithub.com/farhaven) made their first contribution in [bazelbuild/rules_go#3212 **Full Changelog**: bazelbuild/rules_go@v0.33.0...v0.34.0 #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "16e9fca53ed6bd4ff4ad76facc9b7b651a89db1689a2877d6fd7b82aa824e366", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.34.0/rules_go-v0.34.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.34.0/rules_go-v0.34.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.18.4") </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjExNy40In0=-->
](https://renovatebot.com){kind=link}
gcf-merge-on-green bot
pushed a commit
to googleapis/gapic-config-validator
that referenced
this pull request
Jul 19, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.33.0` -> `v0.34.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go</summary> ### [`v0.34.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.34.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.33.0...v0.34.0) #### What's Changed - releaser: fix scrubbing timestamp from patch files by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3180 - Replace Starlark JSON parser with json.decode by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3184 - gopackagesdriver: separates "s" files in pkg info by [@​iamricard](https://togithub.com/iamricard) in [bazelbuild/rules_go#3165 - Refactor away references to @​io_bazel_rules_go by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3185 - Do not print to stderr if cgo linking succeeds after retry by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3187 - Use param files with go-protoc by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3190 - Don't include non-executable go_binary in dependent's runfiles by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3151 - Link in native libraries of transitive dependencies in archive mode by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3186 - runfiles: remove deprecated api by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3198 - Fix failing open hermeticity test by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3206 - Fix go_googleapis Gazelle patch by [@​nickgooding](https://togithub.com/nickgooding) in [bazelbuild/rules_go#3193 - Exclude unsupported C/C++ features by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3189 - Allow gomock to take Bazel common attributes by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/rules_go#3207 - Transition on edges not self by [@​illicitonion](https://togithub.com/illicitonion) in [bazelbuild/rules_go#3116 - Include go_transition_test in bazel aspect by [@​ian-h-chamberlain](https://togithub.com/ian-h-chamberlain) in [bazelbuild/rules_go#3160 - Add an example for go_download_sdk.sdks by [@​fishy](https://togithub.com/fishy) in [bazelbuild/rules_go#3139 - tests: nogo over generated code by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3214 - test nogo/coverage: test generated code by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3213 - Remove references to go_transition_test by [@​linzhp](https://togithub.com/linzhp) in [bazelbuild/rules_go#3215 - Basic bzlmod setup by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3047 - Run BCR tests against Bazel 6.0.0-pre.20220608.2 by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3223 - Use repo-relative labels in MODULE.bazel by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3226 - upkeep: upgrade to go 1.18.3 and gazelle v0.26.0 by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3220 - nogo: ignore generated source files by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3216 - asm: Pass package path with -p by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3231 - bzlmod: Add support for gomock by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3232 - test cgo: ensure helper script works by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3236 - Fix //tests/legacy/examples/cgo:cgo_lib_test on M1 Macs by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3237 - gopackagesdriver: Descend into go_proto_compiler's deps by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/rules_go#3240 - new_library: remove unused resolver by [@​sluongng](https://togithub.com/sluongng) in [bazelbuild/rules_go#3219 - nogo: instantiate type info for generic types when running under Go >=1.18 by [@​farhaven](https://togithub.com/farhaven) in [bazelbuild/rules_go#3212 #### New Contributors - [@​iamricard](https://togithub.com/iamricard) made their first contribution in [bazelbuild/rules_go#3165 - [@​ian-h-chamberlain](https://togithub.com/ian-h-chamberlain) made their first contribution in [bazelbuild/rules_go#3160 - [@​fishy](https://togithub.com/fishy) made their first contribution in [bazelbuild/rules_go#3139 - [@​farhaven](https://togithub.com/farhaven) made their first contribution in [bazelbuild/rules_go#3212 **Full Changelog**: bazelbuild/rules_go@v0.33.0...v0.34.0 #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "16e9fca53ed6bd4ff4ad76facc9b7b651a89db1689a2877d6fd7b82aa824e366", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.34.0/rules_go-v0.34.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.34.0/rules_go-v0.34.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.18.4") </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-config-validator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjExNy40In0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
If a go_binary is built with a non-executable link mode such as
c-archive, its dependents currently pick up a runfile dependency on itsince its DefaultInfo specifies the resulting archive as an executable.
This is unnecessary as the dependent should be able to decide whether to
include the file (e.g. dynamic linking) or not (e.g. static linking).
With this commit, the executable field of the DefaultInfo is only
populated if the go_binary is built with an executable link mode.
Follow-up to #3143