Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use exec paths for rundir #3414

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Do not use exec paths for rundir #3414

merged 3 commits into from
Jan 11, 2023

Commits on Jan 11, 2023

  1. Do not use exec paths for rundir 

    Bazel tests are executed in the runfiles directory, so package relative
paths can be looked up directly by prepending the test's repository
name - it is not necessary (and not correct with
`--nolegacy_external_runfiles`) to use `workspace_root`.
    @fmeum
    fmeum committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    e389552 View commit details
    Browse the repository at this point in the history

  2. Update go/private/rules/test.bzl 

    Co-authored-by: Zhongpeng Lin <zplin@uber.com>
    @fmeum @linzhp
    fmeum and linzhp committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    3304550 View commit details
    Browse the repository at this point in the history

  3. Address review comments

    @fmeum
    fmeum committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    549cddd View commit details
    Browse the repository at this point in the history