Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
The go_googleapis upgrade in 0.38.0 is too disruptive. It changes the Go import paths of the proto packages like
@go_googleapis//google/cloud/dialogflow/cx/v3
and@go_googleapis//google/cloud/dialogflow/v2
, making it necessary to change a large number known imports in Gazelle (bazelbuild/bazel-gazelle#1426), which means that people may not be able to upgrade to rules_go 0.38.0 until we release another version of Gazelle.In addition, it requires other 3rd party packages to use the new import paths too. For example, it requires people to upgrade cloud.google.com/go/dialogflow/apiv2 to at least v1.19.0, which is less than 3 months old, to use the new import path.
We should explore a better upgrade plan, or at least wait a few more months to upgrade go_googleapis. Reverting the upgrade for now.
Other notes for review
I am planning to create a patch release 0.38.1 to include this revert.