Fix handling of linkmode from attr and config setting #3615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
added a commit
that referenced
this pull request
Jul 17, 2023
The value of the flag was always overriden by the `linkmode` `go_binary` attribute, even if that attribute was at its default (`normal`) value. Instead, use a default of `auto` to distinguish this case from the case where no attribute value has been set explicitly. Fixes #3614 Closes #3615 Co-authored-by: Hakan Halil <hhalil@vmware.com>
fmeum
added a commit
that referenced
this pull request
Jul 17, 2023
The value of the flag was always overriden by the `linkmode` `go_binary` attribute, even if that attribute was at its default (`normal`) value. Instead, use a default of `auto` to distinguish this case from the case where no attribute value has been set explicitly. Fixes #3614 Closes #3615 Co-authored-by: Hakan Halil <hhalil@vmware.com>
|
I looked into this and implemented your follow-up suggestion (add a dedicated default value for the |
fmeum
added a commit
that referenced
this pull request
Jul 17, 2023
The value of the flag was always overriden by the `linkmode` `go_binary` attribute, even if that attribute was at its default (`normal`) value. Instead, use a default of `auto` to distinguish this case from the case where no attribute value has been set explicitly. Fixes #3614 Closes #3615 Co-authored-by: Hakan Halil <hhalil@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR enables proper functionality of
go_binaryandgo_testrules with--@io_bazel_rules_go//go/config:linkmode=X, whereXis considered aspiein the context of this text, for simplicity.Previously, when building
go_binaryandgo_testrules with--@io_bazel_rules_go//go/config:linkmode=pie, the configuration parameter would be disregarded due to the presence of a default value for thelinkmodeattribute in the rules. This default attribute value would always be used during the transition.With this update, if
--@io_bazel_rules_go//go/config:linkmode=pieis set, it will be applied to all valid rules through//go/config:linkmode. If both the configuration option and the attribute are set, the attribute takes precedence, providing more precise control.In contrast, if the attribute is explicitly set to "normal", the configuration option will be given priority. To modify this behavior, it might be necessary to update the default value of the
linkmodeattribute to an empty string or use a mechanism (if such exists) that can differentiate between default and user-specified values.Which issues(s) does this PR fix?
Fixes #3614
Other notes for review
Open to testing suggestions.