Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use aspect to infer proto deps automatically #3706

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Use aspect to infer proto deps automatically #3706

wants to merge 5 commits into from

Commits on Nov 29, 2023

  1. Move away from deprecated com_github_golang_protobuf 

    to org_golang_google_protobuf and org_golang_google_grpc.
    @mering
    mering committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    ee727f5 View commit details
    Browse the repository at this point in the history

  2. Restore previous behavior where grpc rule generates both proto and gr… 

    …pc code
    @mering
    mering committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    e7c6979 View commit details
    Browse the repository at this point in the history

  3. Use aspect to infer deps automatically

    @mering
    mering committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    9da42ce View commit details
    Browse the repository at this point in the history

  4. Let aspect return custom provider 

    This is best practice in order to avoid clashing with other aspects who also want to generate go libraries
    @mering
    mering committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    0b67279 View commit details
    Browse the repository at this point in the history

  5. Add gRPC support

    @mering
    mering committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    8c9988f View commit details
    Browse the repository at this point in the history