Support Ivy repos

bazelbuild · Feb 1, 2021 · cbc4581 · cbc4581
1 parent 576cc9d
commit cbc4581
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/coursier.bzl b/coursier.bzl
@@ -829,7 +829,7 @@ def _coursier_fetch_impl(repository_ctx):
         #
         # TODO(https://github.com/bazelbuild/rules_jvm_external/issues/186): Make this work with
         # basic auth.
-        repository_urls = [r["repo_url"].rstrip("/") for r in repositories]
+        repository_urls = [r["repo_url"].rstrip("/") for r in repositories if not r["repo_url"].startswith("ivy:")]
         primary_artifact_path = infer_artifact_path_from_primary_and_repos(primary_url, repository_urls)
 
         mirror_urls = [url + "/" + primary_artifact_path for url in repository_urls]

diff --git a/private/coursier_utilities.bzl b/private/coursier_utilities.bzl
@@ -34,8 +34,7 @@ def strip_packaging_and_classifier(coord):
     # groupId:artifactId:packaging:classifier:version
     coordinates = coord.split(":")
     if len(coordinates) > 4:
-        if coordinates[3] in ["sources", "natives"]:
-            coordinates.pop(3)
+        coordinates.pop(3)
 
     if len(coordinates) > 3:
         # We add "pom" into SUPPORTED_PACKAGING_TYPES here because "pom" is not a