-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support artifact checksum pinning #125
Comments
I'm probably doing this incorrectly, but the
|
Looks like Coursier CLI doesn't support this yet, according to the referenced issue. We may have to do the checksum verification out of band, after downloading the jars and possibly while generating the BUILD targets. |
Would this issue also cover "locking" versions of all transitive dependencies? (Like Cargo.lock etc.) |
My understanding is that locking and pinning are similar to each other. #107 talks about locking top level artifacts to specific versions, but doesn't cover transitive dependencies. Let's continue discussions there? |
Yes, and I imagine lock file generation will involve Bazel WORKSPACE resolve files to a large extent. |
One benefit of a lock file not yet discussed here is that the artifacts are pre-resolved to an artifact URL and shasum. This can save a lot of time every time you would normally need to re-run the coursier resolver (several minutes in our repository). Doing the resolution once and storing that information to a lock file saves us a ton of time in our CI builds. |
@jin any thought on the benefit of a lock file that @JaredNeil mentioned? |
I agree. This is something that I'll discuss with @aehlig, who implemented the Bazel-wide lock file for external repositories ( |
@jin just a follow-up. Any update on the lock file? |
Sorry, no updates on this yet. |
Work in progress to support artifact checksum pinning in a file read and exported by |
From Bazel slack: https://bazelbuild.slack.com/archives/CE6AZNQP7/p1556024364000500
Coursier supports it: coursier/coursier#625The text was updated successfully, but these errors were encountered: