Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
introducing sha-256 checksum support #625
Wow, outstanding PR :-), you thought to all the very little details!
The only thing I'm not sure about is whether SHA-256 checking should be enabled by default right now. This would trigger a lot of failed attempts to download sha 256 checksum, as these aren't too common for now...
I'm thinking about allowing to override the default checkums via the env (e.g.
COURSIER_CHECKSUMS=SHA-256,SHA-1,none) and / or Java properties, I'll push that soon. You could enable SHA-256 checking this way. Would that work for you?
Actually, since I use the library programatically and not in our build system I could just write simply
I don't think using SHA-256 checksums will be standard anytime soon either, so that way I would not need to change the defaults at all.