New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introducing sha-256 checksum support #625

Merged
merged 2 commits into from Aug 4, 2017

Conversation

Projects
None yet
2 participants
@gaboraranyossy-da
Contributor

gaboraranyossy-da commented Jul 28, 2017

Implementing #621. This change introduces support for SHA-256 hashes. The default checksums to use for validation has been changed from SHA1 -> None to SHA-256 -> SHA1 -> None

@alexarchambault

Wow, outstanding PR :-), you thought to all the very little details!

The only thing I'm not sure about is whether SHA-256 checking should be enabled by default right now. This would trigger a lot of failed attempts to download sha 256 checksum, as these aren't too common for now...

I'm thinking about allowing to override the default checkums via the env (e.g. COURSIER_CHECKSUMS=SHA-256,SHA-1,none) and / or Java properties, I'll push that soon. You could enable SHA-256 checking this way. Would that work for you?

@gaboraranyossy-da

This comment has been minimized.

Show comment
Hide comment
@gaboraranyossy-da

gaboraranyossy-da Jul 31, 2017

Contributor

Actually, since I use the library programatically and not in our build system I could just write simply Cache.file(artifact, checksums = Seq(Some("SHA-256"))) at the final step when getting the file.

I don't think using SHA-256 checksums will be standard anytime soon either, so that way I would not need to change the defaults at all.

Contributor

gaboraranyossy-da commented Jul 31, 2017

Actually, since I use the library programatically and not in our build system I could just write simply Cache.file(artifact, checksums = Seq(Some("SHA-256"))) at the final step when getting the file.

I don't think using SHA-256 checksums will be standard anytime soon either, so that way I would not need to change the defaults at all.

@gaboraranyossy-da

This comment has been minimized.

Show comment
Hide comment
@gaboraranyossy-da

gaboraranyossy-da Aug 2, 2017

Contributor

@alexarchambault would it be possible to merge this master and create a new release?

Contributor

gaboraranyossy-da commented Aug 2, 2017

@alexarchambault would it be possible to merge this master and create a new release?

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Aug 4, 2017

Member

1.0.0-RC9 will be released once #627 is merged.

Member

alexarchambault commented Aug 4, 2017

1.0.0-RC9 will be released once #627 is merged.

@alexarchambault alexarchambault merged commit 8f3a82f into coursier:master Aug 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

alexarchambault added a commit that referenced this pull request Aug 4, 2017

introducing sha-256 checksum support (#625)
introducing sha-256 checksum support
@gaboraranyossy-da

This comment has been minimized.

Show comment
Hide comment
@gaboraranyossy-da

gaboraranyossy-da Aug 4, 2017

Contributor

thanks!

Contributor

gaboraranyossy-da commented Aug 4, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment