Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a flag to fetch javadoc for maven artifacts #494

Closed
erickj opened this issue Dec 4, 2020 · 2 comments
Closed

add a flag to fetch javadoc for maven artifacts #494

erickj opened this issue Dec 4, 2020 · 2 comments

Comments

@erickj
Copy link
Contributor

erickj commented Dec 4, 2020

just a feature request, that it would be nice to be able to use coursier's ability to fetch javadocs as additional artifacts. this requires additional support, similar to the fetch_sources flags because the underlying coursier command must be modified to use the --javadoc flag
erickj added a commit to erickj/rules_jvm_external that referenced this issue Dec 4, 2020
@erickj
Adds a flag to fetch javadoc targets (bazelbuild#494)
6b7822a 
Adds flag fetch_javadoc to maven_install rules. When used, javadoc for
all targets will be fetched by coursier and placed in a similarly
named filegroup.
@erickj
Copy link
Contributor Author

erickj commented Dec 4, 2020 •
edited
Loading

created pull request #495

shs96c pushed a commit that referenced this issue Dec 4, 2020
@erickj
Adds a flag to fetch javadoc targets (#494) (#495)
6143a6e 
Adds flag fetch_javadoc to maven_install rules. When used, javadoc for
all targets will be fetched by coursier and placed in a similarly
named filegroup.
@jin jin mentioned this issue Jan 6, 2021
Closed
4 tasks
@jin
Copy link
Member

jin commented Jan 6, 2021

Merged in #495.

@jin jin closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erickj @jin